(04-11-2017, 10:35 AM)Arrei Wrote: Good find. But before any such configuration options are changed, is there any info around on what else changing that setting might affect? Wouldn't be any good to fix one problem only to break something else about hoppers, after all.
Hi Arrei,
Yeah I know what you're thinking, LWC and other chest related plugins as well as hoppers. The only thing I can say is from a totally clean install with no configuration files from a previous install, the server created all the yml configuration files from scratch the first time it was run (not including the restart for EULA agreement!).
Therefore on a new install it would seem that when the server creates the paperclip.yml for the first time the new default for hoppers is push-based: false.
As I said previously after I saw the transfer working correctly, I stopped the server and played devil's advocate and edited paperclip.yml and set push-based: true. Sure enough it broke the transfer so I feel sure it's the answer.
Another interesting question came to mind yesterday and that was, when was this default setting implemented? It might be it was a number of versions ago but as updating server jar files does not replace the originally created configuration files unless coded to make a change, it is an unknown.
Could I say for sure that this setting won't break a plugin? To be perfectly honest no I can't, all I can say is that it appears it is now the default setting on a newly run paperclip.jar.
The only thing I can really suggest is at a quiet time have some tests written down like LWC, Essentials Server trade stuff, chestshop and any other plugins that I don't know about and try and break them whilst white listed. I would however suggest frost makes a few db/yml backups first
One can only hope that as they have now decided to set the default to false that someone might have written somewhere about an issue.
When I wrote the above paragraph I suddenly remembered I had a previous paperclip install in another directory. The date on the files is 18th of Feb 2017. I just looked in the paperclip.yml and the setting is false there too, so at least there has been some time for others to yelp if something has broken. Better to be safe than sorry though.
If I can help test anything please let me know, but I'm a little hesitant as I could be running the same plugins but just have one different setting in a plugin configuration yml and it would throw any tests off from the plugins on HT.
All the best,
Clee